Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extractors/services): add dnsmasq #20

Merged
merged 1 commit into from
May 1, 2024
Merged

Conversation

IogaMaster
Copy link
Contributor

@IogaMaster IogaMaster commented Apr 26, 2024

Converts the dns, domain to address mappings into details

        services.dnsmasq = {
          enable = true;
          settings.address = [
            "/home.lan/192.168.25.125"
            "/example.com/192.168.25.25"
          ];
        };

image

@JayRovacsek
Copy link
Contributor

Ah, very nice idea!

Just some thoughts (and not meant to be feedback for this PR but food for thought in the future)
I could see some configurations becoming quite large in mappings they might have configured, so just noting we might want to return to the parsing of settings.addresses as possibly split from normal vs detailed view (pending where/if #15 changes that concept into the future)

All in all, I love it - going to add a similar split to blocky if there is appetite to merge this 😍

@IogaMaster
Copy link
Contributor Author

IogaMaster commented Apr 27, 2024

I agree, in #19. Caddy can serve many services and load balance, which can add quite a few options. So possibly adding a threshold, where after let's say 10 lines, all others are hidden behind ....
Then the detailed view would have all of the details, ignoring the threshold.

Copy link
Contributor

@JayRovacsek JayRovacsek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, two comments that might require attention 👍

nixos/extractors/services.nix Outdated Show resolved Hide resolved
nixos/extractors/services.nix Outdated Show resolved Hide resolved
@IogaMaster
Copy link
Contributor Author

@oddlama The issues have been fixed

@IogaMaster IogaMaster force-pushed the dnsmasq branch 2 times, most recently from 1528de0 to 8dda824 Compare May 1, 2024 20:08
@IogaMaster
Copy link
Contributor Author

@oddlama Merge conflicts fixed

@oddlama
Copy link
Owner

oddlama commented May 1, 2024

Awesome! Thanks a lot!

@oddlama oddlama merged commit 744d2d7 into oddlama:main May 1, 2024
@IogaMaster IogaMaster deleted the dnsmasq branch May 2, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants