Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update keystore-idb #286

Merged
merged 3 commits into from
Sep 14, 2021
Merged

Update keystore-idb #286

merged 3 commits into from
Sep 14, 2021

Conversation

icidasset
Copy link
Contributor

Implements the 0.15 keystore-idb changes.
Still uses an alpha release, will replace before merging.

matheus23
matheus23 approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@matheus23 matheus23 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
I think we should add a changelog item for this change. Just in case anyone is wondering why (await webnative.keystore.get()).publicReadKey() isn't working anymore.
Let's get this into the v0.28 release :)

@icidasset icidasset merged commit 6b15627 into main Sep 14, 2021
@icidasset icidasset deleted the icidasset/update-keystore branch September 14, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matheus23 matheus23 matheus23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@icidasset @matheus23