Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shorthand accountDID method #463

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Add shorthand accountDID method #463

merged 2 commits into from
Jan 19, 2023

Conversation

icidasset
Copy link
Contributor

Closes #443

program.accountDID(username)

I thought about doing just program.accountDID() without the username param which would depend on the session underneath and return null if not authed. But seeing that loadFileSystem also takes the username parameter, it makes sense to implement it that way.

Copy link
Member

@bgins bgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

Copy link
Member

@avivash avivash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh nice, looks good!

@icidasset icidasset merged commit 7af4952 into main Jan 19, 2023
@icidasset icidasset deleted the icidasset/account-did branch January 19, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add shorthand rootDID method
3 participants