Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove fs.add and fs.cat #465

Merged
merged 2 commits into from
Jan 19, 2023
Merged

Remove fs.add and fs.cat #465

merged 2 commits into from
Jan 19, 2023

Conversation

icidasset
Copy link
Contributor

Matches the interface of rs-wnfs.

Closes #440

Guide will need updating:
https://guide.fission.codes/developers/webnative/file-system-wnfs

bgins
bgins approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@bgins bgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! This is an excellent improvement, read and write are much clearer. 💯

avivash
avivash approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@avivash avivash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, i like not having these aliased anymore 👍🏼 i'll look through the templates to confirm we aren't using any of the old aliased methods

@avivash
Copy link
Member

avivash commented Jan 18, 2023

Looks like all four templates are only using fs.write and fs.read already 👍🏼

Base automatically changed from icidasset/account-did to main January 19, 2023 09:14
@icidasset icidasset merged commit 57beaf1 into main Jan 19, 2023
@icidasset icidasset deleted the icidasset/read-write branch January 19, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avivash avivash avivash approved these changes

@bgins bgins bgins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove fs.add and fs.cat
3 participants
@icidasset @avivash @bgins