Skip to content

Commit

Permalink
Allow to use higher versions of prometheus_client
Browse files Browse the repository at this point in the history
Fixes matrix-org#7641

The package was pinned to <0.8.0 without an obvious reasoning with
7ad1d76
in matrix-org#5636
while the version selection looks to just try to exclude an arbitrary
next minor version number that might introduce API breaking changes.
Selecting the next minor number might be a good conservative selection.

Downstream distributions already reported success patching out the version
requirements.

This also fixes the integration of upgraded packages into openSUSE packages,
e.g. for openSUSE Tumbleweed which already ships prometheus_client >= 0.8 .

Signed-off-by: Oliver Kurz <okurz@suse.de>
  • Loading branch information
okurz committed Jul 3, 2020
1 parent fedb632 commit 9b543b1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions changelog.d/7780.misc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Allow to use higher versions of prometheus_client <0.9.0 which are expected to introduce no breaking changes. Contributed by Oliver Kurz.
2 changes: 1 addition & 1 deletion synapse/python_dependencies.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
"msgpack>=0.5.2",
"phonenumbers>=8.2.0",
"six>=1.10",
"prometheus_client>=0.0.18,<0.8.0",
"prometheus_client>=0.0.18,<0.9.0",
# we use attr.s(slots), which arrived in 16.0.0
# Twisted 18.7.0 requires attrs>=17.4.0
"attrs>=17.4.0",
Expand Down

0 comments on commit 9b543b1

Please sign in to comment.