Skip to content

Commit

Permalink
Update to support PHP 8 and remove unused code comments
Browse files Browse the repository at this point in the history
This commit updates the minimum supported PHP version in our CI workflow and composer.json file to PHP 8. Also, the PHP versions tested against is now expanded to  include 8.2 and 8.3. Furthermore, unnecessary ‘inheritdoc’ comments have been removed to improve code readability. The 'WebDriver' class has been enriched too with PHP 8 attribute modifications for method input types. Lastly, the README and copyright years have been updated. These changes are important to keep the project maintained with the latest PHP releases and standards.
  • Loading branch information
oleg-andreyev committed Jul 11, 2023
1 parent a062610 commit 697c29e
Show file tree
Hide file tree
Showing 6 changed files with 154 additions and 118 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php: [ 7.4 ]
php: [ 8.2 ]
steps:
- uses: actions/checkout@v3
- uses: shivammathur/setup-php@v2
Expand Down Expand Up @@ -48,11 +48,11 @@ jobs:
strategy:
fail-fast: false
matrix:
php: [ 7.4, 8.0, 8.1 ]
php: [ 8.0, 8.1, 8.2 ]
browser: [ chrome, firefox ]
experimental: [false]
include:
- php: 8.2
- php: 8.3
experimental: true
browser: chrome
continue-on-error: ${{ matrix.experimental }}
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Initially it's started as [PR](https://github.com/minkphp/MinkSelenium2Driver/pu

Major updates include:
- Switch to using `facebook/webdriver`
- Update minimum php version to 7.4
- Update minimum php version to 8.0
- Tested against the latest Google Chrome and Mozilla Firefox both in GUI and Headless modes

## Setup
Expand Down Expand Up @@ -34,4 +34,4 @@ Follow https://github.com/shivammathur/setup-php#local-testing-setup

## Copyright

Copyright (c) 2022 Oleg Andreyev <oleg@andreyev.lv>
Copyright (c) 2023 Oleg Andreyev <oleg@andreyev.lv>
9 changes: 5 additions & 4 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,17 @@
}
],
"require": {
"php": ">=7.4",
"behat/mink": "^1.8",
"php-webdriver/webdriver": "^1.8"
"php": ">=8.0",
"behat/mink": "^1.10",
"php-webdriver/webdriver": "^1.14"
},
"require-dev": {
"ext-json": "*",
"roave/security-advisories": "dev-master",
"mink/driver-testsuite": "dev-integration-branch",
"behat/mink-extension": "^2.3",
"bamarni/composer-bin-plugin": "^1.8"
"bamarni/composer-bin-plugin": "^1.8",
"jetbrains/phpstorm-attributes": "^1.0"
},
"scripts": {
"bin": "echo 'bin not installed'",
Expand Down
Loading

0 comments on commit 697c29e

Please sign in to comment.