Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<scale> argument of guides() cannot be FALSE`. Use "none" instead as of ggplot2 3.3.4 #28

Open
moa4020 opened this issue Jan 19, 2023 · 1 comment

Comments

@moa4020
Copy link

moa4020 commented Jan 19, 2023

Hey!

I'm using ggseqlogo to produce logoplots of Bstringset objects on R. The only line of code I've used ggseqlogo is the line below.

out = ggseqlogo(sequences, method = 'prob' )

The following warning message appeared when I ran the code. I have been getting the right results. But is there something I need to look out for?

Warning message:
The <scale> argument of guides() cannot be FALSE. Use "none" instead as of ggplot2 3.3.4.
ℹ The deprecated feature was likely used in the ggseqlogo package.
Please report the issue at https://github.com/omarwagih/ggseqlogo/issues.
This warning is displayed once every 8 hours.
Call lifecycle::last_lifecycle_warnings() to see where this warning was generated.

I called 'lifecycle::last_lifecycle_warnings()' as instructed and got the following backtrace.

lifecycle::last_lifecycle_warnings()
[[1]]
<warning/lifecycle_warning_deprecated>
Warning:
The <scale> argument of guides() cannot be FALSE. Use "none" instead as of ggplot2 3.3.4.
ℹ The deprecated feature was likely used in the ggseqlogo package.
Please report the issue at https://github.com/omarwagih/ggseqlogo/issues.


Backtrace:

  1. ggseqlogo::ggseqlogo(sequences, method = "prob")
  2. ggseqlogo::geom_logo(data = data, ...)
  3. ggplot2::guides(fill = F)
  4. ggplot2:::deprecate_warn0("3.3.4", "guides(<scale> = 'cannot be FALSE. Use "none" instead')")
@omarwagih
Copy link
Owner

Thanks for reporting. Nothing you need to worry about in this version but this will probably break in future versions. I'll address this soon.

aviezerl added a commit to aviezerl/ggseqlogo that referenced this issue Sep 6, 2023
Fixes <scale>` argument of `guides()` cannot be `FALSE`. Use "none" instead as of ggplot2 3.3.4 omarwagih#28
Fixes Deprecated feature from ggplot2 3.3.4 used in ggseqlogo omarwagih#32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants