Skip to content
This repository has been archived by the owner on Dec 5, 2021. It is now read-only.

omgx integration #146

Closed
wants to merge 5 commits into from
Closed

Conversation

InoMurko
Copy link

@InoMurko InoMurko commented Jul 1, 2021

No description provided.

@InoMurko
Copy link
Author

InoMurko commented Jul 1, 2021

I've deleted omgx-sync-tests.yml because I think it's a duplicate of sync-tests.yml.

These tests really just test verifier and replica.

omgx-integration.yml has commented out the original Optimism integration tests. The old develop had them enabled and the reason for it was that it allowed us check whether our containers somehow interfere with the original containers. Just putting this out there in case @jliphard decides to enable them back.

@InoMurko InoMurko force-pushed the inomurko/enable_omgx_integration branch from 1da6a11 to 54f2fcc Compare July 1, 2021 09:31
@InoMurko
Copy link
Author

InoMurko commented Jul 1, 2021

I see that creating an omgx docker - compose overlay was commented out:

# yq eval '(.services.[].image | select(. == "ethereumoptimism*")) |= sub("ethereumoptimism", "omgx")' ${ORIGINAL_DOCKERFILE} | \
# yq eval '(.services.[].image) += ":latest"' - \
# > ${DOCKERFILE}

This means we're relying on Optimisms push of container images into their docker hub. Not ours. So their latest container could in in front of our containers and there could be discrepancies the way the system is functioning.

If you use the up_local pull functionality without omgx docker compose overlay, you get very old containers:

REPOSITORY                              TAG       IMAGE ID       CREATED        SIZE
omgx/omgx_deployer                      latest    3b1a522e7408   8 hours ago    1.01GB
omgx/omgx_builder                       latest    19d815f22f6e   8 hours ago    3.76GB
ethereumoptimism/builder                latest    1f952ca4ae99   5 days ago     1.14GB
ethereumoptimism/deployer               latest    538e0b70d62b   **2 months ago**   1.54GB
ethereumoptimism/batch-submitter        latest    d525dc90394e   **2 months ago**   1.53GB
ethereumoptimism/data-transport-layer   latest    f9c6ad8f02ed   **2 months ago**   1.39GB
ethereumoptimism/message-relayer        latest    0b1e3a1fe302   **2 months ago**   1.25GB
ethereumoptimism/integration-tests      latest    3ceed3144a81   **2 months ago**   2.22GB
ethereumoptimism/hardhat                latest    3a2236160798   **3 months ago**   1.12GB

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2021

Codecov Report

Merging #146 (f965e0e) into develop (c7ebd2c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #146   +/-   ##
========================================
  Coverage    86.05%   86.05%           
========================================
  Files           49       49           
  Lines         1936     1936           
  Branches       307      307           
========================================
  Hits          1666     1666           
  Misses         270      270           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7ebd2c...f965e0e. Read the comment docs.

@InoMurko InoMurko force-pushed the inomurko/enable_omgx_integration branch from 9bed660 to afb06d2 Compare July 1, 2021 14:42
@CAPtheorem
Copy link

Most changes incorporated into #149.

@InoMurko
Copy link
Author

InoMurko commented Jul 2, 2021

okay, so should this be closed?

@CAPtheorem
Copy link

yes, can be closed

@CAPtheorem CAPtheorem closed this Jul 2, 2021
@InoMurko InoMurko deleted the inomurko/enable_omgx_integration branch July 5, 2021 06:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants