Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

one_hot_encoder: TSQL vs. boolean type #9

Merged
merged 4 commits into from
Mar 18, 2021

Conversation

dataders
Copy link
Contributor

changes

in support of making this macro compatible with TSQL, I:

  • moved the logic that generates the included columns into the core macro which means:
    • the default__ and adapter__ macros don't require include_columns and exclude_columns, only col_list
  • implemented sqlserver__one_hot_encoder in which:
    • true false and boolean is replaced with 1, 0, and bit

Related PRs and issues

#6, #7, #8

@jamesweakley
Copy link
Contributor

nice refactor, thanks for that

@jamesweakley jamesweakley merged commit 09191fe into omnata-labs:main Mar 18, 2021
@dataders dataders deleted the boolean-type branch March 19, 2021 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants