Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'fail' to 'failure' #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dibby-dibby
Copy link

failure is more suitable here, because just like 'success', 'failure' is a noun unlike 'fail' which is a verb.

@sblomberg
Copy link

I prefer not making this change, as it is has the potential to break existing APIs that check for status: "fail" In addition to its verb usage, fail can be a noun per http://m-w.com/dictionary/fail

@xzilla
Copy link
Member

xzilla commented Aug 13, 2020

ISTM this is one of those cases where if we were starting from day 1, we might be inclined to go success|failure, but the cost to make the change (aka breaking backwards compatibility) seems higher than the value.

@feyton
Copy link

feyton commented Jan 14, 2022

I prefer "fail" over failure. Although it might seem natural, the first is more understandable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants