Added rules to remove unsupported compiler flags #2369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomflinda
reviewed
Sep 20, 2024
Comment on lines
+15
to
+17
| string(APPEND CMAKE_C_FLAGS " -prec_div") | ||
| string(APPEND CMAKE_CXX_FLAGS " -parallel") | ||
| string(APPEND CMAKE_CXX_FLAGS " -wd188,186,144,913,556,858,597,177,1292,167,279,592,94,2722,3199") |
There was a problem hiding this comment.
- These three options are not NVCC-specific options, which compiler uses those options?
- In my opinion, if it is only used in a specific application for a specific compiler, we can implement those migration rules as application-specific rules?
There was a problem hiding this comment.
- These options are used by Intel Classical C Compiler (ICC) - ref
- I haven't found any other examples of apps using these flags yet
There was a problem hiding this comment.
Then, I suggest that those migration rules should be implemented as application-specific rules.
There was a problem hiding this comment.
It's kind of migration knowledge, how about put it into a separate cmake_script_migration_rule_optional.yaml?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CMake rules to remove unsupported compiler flags