[SYCLomatc][Intercept-build] Refine intercept-build to work as normal compilation if the toolchain is available #2386
+80
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomflinda
force-pushed
the
refine_intercept_build
branch
from
f0e3089
to
351e6a9
Compare
zhiweij1
approved these changes
Oct 8, 2024
tomflinda
changed the title
tomflinda
changed the title
| int is_ar_staticlib_cmd = 0; | ||
| int is_tool_existence = 0; | ||
| if (file_exists(argv[0])) { | ||
| is_tool_existence = 1; |
| int has_parenthesis = 0; | ||
| if (is_tool_existence) { | ||
| for (size_t it = 0; it < argc; ++it) { | ||
| fprintf(fd, "%s%c", argv[it], US); |
There was a problem hiding this comment.
debug purpose printf?
There was a problem hiding this comment.
No, it is used to collect options for current command.
| ret = 0; // intercept-stub should continue to run. | ||
|
|
||
| // intercept-stub is used to handle the compiler command like | ||
| // "/bin/sh -c clang++ -c `echo ./`hello.c", it changes the compiler |
There was a problem hiding this comment.
please keep footprint as small as possible for a PR.
There was a problem hiding this comment.
Those codes are in the else branch in the code below, logic keeps same as old code
if (is_tool_existence) {
for (size_t it = 0; it < argc; ++it) {
fprintf(fd, "%s%c", argv[it], US);
}
} else {
...
}
| if (ret == 1 && it_cp == 0 && !is_ar_staticlib_cmd) { | ||
| exit(0); | ||
| if(is_tool_existence) { | ||
| return 0; |
There was a problem hiding this comment.
it's void function, so why " return 0"?
There was a problem hiding this comment.
It is not void function, shown as follows:
static int bear_report_call(char const *fun, char const *argv[]) {
#else
static void bear_report_call(char const *fun, char const *const argv[]) {
#endif // SYCLomatic_CUSTOMIZATION
| } | ||
| return call_eaccess(pathname, mode); | ||
| } | ||
|
|
There was a problem hiding this comment.
I think we should keep this.
There was a problem hiding this comment.
Yes, we keep it, just do a little refinement.
tomflinda
force-pushed
the
refine_intercept_build
branch
from
351e6a9
to
4721319
Compare
… compilation if all the toolchains are available Signed-off-by: chenwei.sun <chenwei.sun@intel.com>
Signed-off-by: chenwei.sun <chenwei.sun@intel.com>
Signed-off-by: chenwei.sun <chenwei.sun@intel.com>
Signed-off-by: chenwei.sun <chenwei.sun@intel.com>
Signed-off-by: chenwei.sun <chenwei.sun@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: chenwei.sun chenwei.sun@intel.com