Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color_mode VelocityRainbow #454

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

stephen322
Copy link
Contributor

@stephen322 stephen322 commented Jul 12, 2023

Adds a color mode to show the velocity of notes.

There were a lot of places to touch to add a color mode so I can't be sure I handled everywhere correctly. In particular, I don't have a menulcd, nor do I use sequences, so they are untested and probably incomplete.

@onlaj
Copy link
Owner

onlaj commented Jul 12, 2023

Hello.
Thank you for your contribution.
Indeed, the menu on lcd and sequences seems to be broken, I will try to fix them.
Also, settings.xml needs to be updated too, to include new settings, I will take care of it.

@onlaj onlaj changed the base branch from master to velocity_rainbow July 12, 2023 09:27
Copy link
Owner

@onlaj onlaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you don't have waveshare screen I will make changes related to menu myself. Everything else looks fine.

@onlaj onlaj merged commit 1bb656c into onlaj:velocity_rainbow Jul 12, 2023
@stephen322 stephen322 deleted the velocity_rainbow branch July 13, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants