-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pyflakes from CI #4371
Remove pyflakes from CI #4371
Conversation
Signed-off-by: Justin Chu <justinchu@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for the updates! In the future we can add pyflakes back after it has supported diff_context.
We prob don't need to reenable pyflakes because flake8 is supposed to include pyflakes. We just need to configure flake8 properly (to enable those checks) |
That's good to know. |
I think that's just a templated readme that's not updated |
You are right 👍 |
Signed-off-by: Justin Chu <justinchu@microsoft.com>
Description
pyflakes does not support diff_context, creating too much noise. So we disable it.