Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move mypy config from setup.cfg to pyproject.toml #4542

Merged
merged 5 commits into from
Oct 1, 2022

Conversation

jcwchen
Copy link
Member

@jcwchen jcwchen commented Sep 23, 2022

Description

Move mypy config from setup.cfg to pyproject.toml

Motivation and Context

Closes #4538.

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen jcwchen requested a review from a team as a code owner September 23, 2022 21:54
@jcwchen jcwchen added the code style Issues related to coding style or the linter label Sep 23, 2022
Copy link
Contributor

@justinchuby justinchuby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🚀

pyproject.toml Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
@jcwchen jcwchen merged commit 96e5c3c into onnx:main Oct 1, 2022
@jcwchen jcwchen deleted the jcw/move-mypy branch October 1, 2022 16:26
broune pushed a commit to broune/onnx that referenced this pull request May 6, 2023
* move mypy config from setup.cfg to pyproject.toml

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* move pylint

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

* fix merge conflict

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>

Signed-off-by: Chun-Wei Chen <jacky82226@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code style Issues related to coding style or the linter
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Move mypy config to pyproject.toml
3 participants