New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for SparkML KMeansModel conversion #556

Merged

xadupre merged 6 commits into onnx:main from memoryz:jasowang/gh538

Jun 4, 2022

Contributor

memoryz commented May 29, 2022

memoryz force-pushed the jasowang/gh538 branch from 7277997 to 6e29fcc Compare

May 29, 2022 00:50


          feat: add support for SparkML KMeansModel conversion

b6cff38

Signed-off-by: Jason Wang <jasowang@microsoft.com>

memoryz force-pushed the jasowang/gh538 branch from 6e29fcc to b6cff38 Compare

May 31, 2022 17:34

lgtm-com bot commented May 31, 2022

This pull request fixes 1 alert when merging b6cff38 into 66c817e - view on LGTM.com

fixed alerts:

1 for Unused import


          lowering div/add operator to version 13

95a2a4d

Signed-off-by: Jason Wang <jasowang@microsoft.com>

lgtm-com bot commented May 31, 2022

This pull request fixes 1 alert when merging 95a2a4d into 66c817e - view on LGTM.com

fixed alerts:

1 for Unused import

Contributor Author

memoryz commented Jun 1, 2022

@xadupre This is ready for review.

xadupre reviewed

View reviewed changes

onnxmltools/convert/sparkml/operator_converters/k_means.py Outdated Show resolved Hide resolved

xadupre reviewed

View reviewed changes

onnxmltools/convert/sparkml/operator_converters/k_means.py Outdated Show resolved Hide resolved

xadupre reviewed

View reviewed changes

onnxmltools/convert/sparkml/operator_converters/k_means.py Outdated Show resolved Hide resolved

xadupre reviewed

View reviewed changes

tests/sparkml/test_k_means.py Outdated Show resolved Hide resolved

memoryz added 2 commits

June 1, 2022 12:44


          fixing comments

0fd6b9b

Signed-off-by: Jason Wang <jasowang@microsoft.com>


          removing default op_domain

9b98131

Signed-off-by: Jason Wang <jasowang@microsoft.com>

lgtm-com bot commented Jun 1, 2022

This pull request fixes 1 alert when merging 9b98131 into 66c817e - view on LGTM.com

fixed alerts:

1 for Unused import


          fixing unit test breaks

81e003a

Signed-off-by: Jason Wang <jasowang@microsoft.com>

lgtm-com bot commented Jun 1, 2022

This pull request fixes 1 alert when merging 81e003a into 66c817e - view on LGTM.com

fixed alerts:

1 for Unused import

Contributor Author

memoryz commented Jun 1, 2022

@xadupre ready for another round of code review.

xadupre reviewed

View reviewed changes

onnxmltools/convert/sparkml/operator_converters/k_means.py Outdated Show resolved Hide resolved


          requiring target opset to be >= 7 in order to use broadcast in add an…

bbffe0c

…d div

Signed-off-by: Jason Wang <jasowang@microsoft.com>

memoryz force-pushed the jasowang/gh538 branch from 273515a to bbffe0c Compare

June 2, 2022 00:54

lgtm-com bot commented Jun 2, 2022

This pull request fixes 1 alert when merging bbffe0c into 66c817e - view on LGTM.com

fixed alerts:

1 for Unused import

Contributor Author

memoryz commented Jun 2, 2022

@xadupre ready for another round of code review. :)

Contributor Author

memoryz commented Jun 4, 2022

xadupre approved these changes

View reviewed changes

xadupre merged commit 0a40d6d into onnx:main

memoryz deleted the jasowang/gh538 branch

June 8, 2022 01:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet