loading of ModelPlugins from docker image #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanCondon
added
enhancement
shadansari
approved these changes
Feb 5, 2020
|
Just waiting on onosproject/onos-config#1081 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a method for loading model plugins from Docker images as sidecars to
onos-configWhen the plugin container is loaded it copies its
.sofile to a shared folder whereonos-configcan access it as a file and load it with-modelPlugin.This is the recommended way of sharing files between sidecar containers. See https://kubernetes.io/docs/tasks/access-application-cluster/communicate-containers-same-pod-shared-volume/
Currently I am generating the model plugin Docker image in onosproject/config-models#1
but this creates a model plugin that's incompatible with
onos-config. I will fix this and will try to merge this then.