fix switch input for boolean type as Deprecated

ontoportal-lirmm · Nov 27, 2023 · 0e26249 · 0e26249
1 parent af08bb6
commit 0e26249
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/app/components/switch_input_component.rb b/app/components/switch_input_component.rb
@@ -15,7 +15,7 @@ def initialize(id:, name: , label: '', value: '', checked: false, boolean_switch
   end
 
   def boolean_switch_action
-    "this.previousElementSibling.value = this.previousElementSibling.value !== 'true'" if @boolean_switch
+    "this.parentElement.previousElementSibling.value = this.parentElement.previousElementSibling.value !== 'true'" if @boolean_switch
   end
 
   def check_box_name

diff --git a/app/components/switch_input_component/switch_input_component.html.haml b/app/components/switch_input_component/switch_input_component.html.haml
@@ -1,8 +1,8 @@
 %div.switch-filter
-  - if @boolean_switch
-    = hidden_field_tag @name, @value
   - if content || !@label.empty?
     = content_tag(:div, content || @label, style: @style)
+  - if @boolean_switch
+    = hidden_field_tag @name, @value
   %label.switch{for: check_box_id}
     = check_box_tag  check_box_name, @value, @checked, class: '', id:  check_box_id, onChange: "#{boolean_switch_action}"
     %span.slider
diff --git a/app/helpers/submission_inputs_helper.rb b/app/helpers/submission_inputs_helper.rb
@@ -389,7 +389,9 @@ def generate_boolean_input(attr)
     value = value.to_s unless value.nil?
     name = attr.name
     content_tag(:div, class: 'd-flex') do
-      switch_input(id: name, name: name, label: attr_header_label(attr), checked: value.eql?('true'), value: value, boolean_switch: true, style: 'font-size: 14px;')
+      switch_input(id: name, name: name, label: attr_header_label(attr), checked: value.eql?('true'), value: value,
+                   boolean_switch: true,
+                   style: 'font-size: 14px;')
     end
   end