Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: fair_score requests with fairness disabled #232

Closed
RaimiSol opened this issue Apr 5, 2023 · 1 comment
Closed

Bug: fair_score requests with fairness disabled #232

RaimiSol opened this issue Apr 5, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@RaimiSol
Copy link

RaimiSol commented Apr 5, 2023

I have globally set:
$FAIRNESS_DISABLED = true

Using the chrome dev tools it can be shown that erroneous requests are made related to fair_score.js.

My estimated reason is:

  1. In application.js:L29: //= require fair_score
  2. In fair_score.js:L634 & L656 & L678: jQuery("#fairness_assessment").ready( ... ) and jQuery("#fair-home").ready( ... ) and jQuery('#fair-summary').ready( ... )

According to the jQuery documentation (.ready) jQuery("#fairness_assessment").ready is equivalent to $( document ).ready which leads to the unexpected behaviour.

@syphax-bouazzouni syphax-bouazzouni added the bug Something isn't working label Apr 5, 2023
syphax-bouazzouni pushed a commit that referenced this issue Jun 14, 2023
syphax-bouazzouni pushed a commit that referenced this issue Jun 14, 2023
syphax-bouazzouni pushed a commit that referenced this issue Jun 14, 2023
Part of the work on issue #232. Fixes Rails dynamic route deprecation warnings.
@syphax-bouazzouni
Copy link
Collaborator

Fixed in #335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants