Feature: Extract card message component #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract the popup we're using to show success messages ... to make it reusable
Bilelkihal
changed the title
Bilelkihal
changed the title
syphax-bouazzouni
requested changes
Jan 25, 2023
syphax-bouazzouni
requested changes
Jan 30, 2023
| @type = type | ||
| case type | ||
| when "success" | ||
| @icon = "green-check.svg" |
There was a problem hiding this comment.
Add the SVG files to this PR
| @@ -0,0 +1,16 @@ | |||
| class CardMessageComponent < ViewComponent::Base | |||
| def initialize(title: ,message:, button_text:, type:) | |||
| #if title == "no-title" then the component has no title | |||
There was a problem hiding this comment.
don't do comments , write code
syphax-bouazzouni
approved these changes
Feb 3, 2023
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
On different occasions, we need to show the user a message for success, failure ...
in these messages, we use the same design and we change just the content,
so we gonna have a repeated code in several places of our app.
Solution:
I extracted the message popup as a reusable component that we can change the message, icon, and text button of it.