forked from ontoportal/ontoportal_web_ui
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add feedback for empty attributes in concepts #231
Merged
syphax-bouazzouni
merged 16 commits into
development
from
feature/add-not-available-value-text-concept
May 25, 2023
Merged
Feature: Add feedback for empty attributes in concepts #231
syphax-bouazzouni
merged 16 commits into
development
from
feature/add-not-available-value-text-concept
May 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haddadzineddine
changed the title
Include 'not available' text for missing preferred and preferred label values in the selected language.
Add feedback for empty attributes in concepts
Apr 4, 2023
haddadzineddine
changed the title
Add feedback for empty attributes in concepts
Feature | Add feedback for empty attributes in concepts
Apr 24, 2023
syphax-bouazzouni
requested changes
May 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed in our last meeting:
- Show the warning only if the preferred name is empty
- Do a better style and reuse the alert component
We will need a screenshot when done |
syphax-bouazzouni
force-pushed
the
development
branch
from
May 7, 2023 01:29
e4a9b5c
to
17c589c
Compare
[x] Modify the existing alert component. [x] Add the alert component to the lookbook.
…d-not-available-value-text-concept
In this scenario, I display the alert message regardless of the existence of the preferred name, simply to demonstrate that it functions properly. |
syphax-bouazzouni
changed the title
Feature | Add feedback for empty attributes in concepts
Feature: Add feedback for empty attributes in concepts
May 25, 2023
syphax-bouazzouni
added a commit
that referenced
this pull request
Sep 5, 2023
…le-value-text-concept Feature: Add feedback for empty attributes in concepts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When selecting a specific language, it is possible that the
Preferred Name
andprefLabel
attributes may be empty. To inform the user that these attributes do not have a value in the selected language, we need to add feedback.Screenshots:
synonyms and definitions :
prefLabel :
Preferred name :
Reviewers
@syphax-bouazzouni