Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add feedback for empty attributes in concepts #231

Merged

Conversation

haddadzineddine
Copy link

@haddadzineddine haddadzineddine commented Apr 4, 2023

Description

When selecting a specific language, it is possible that the Preferred Name and prefLabel attributes may be empty. To inform the user that these attributes do not have a value in the selected language, we need to add feedback.

Screenshots:

  1. synonyms and definitions :
    image

  2. prefLabel :
    image

  3. Preferred name :
    image

Reviewers

@syphax-bouazzouni

@haddadzineddine haddadzineddine changed the title Include 'not available' text for missing preferred and preferred label values in the selected language. Add feedback for empty attributes in concepts Apr 4, 2023
@haddadzineddine haddadzineddine self-assigned this Apr 4, 2023
@haddadzineddine haddadzineddine added the enhancement New feature or request label Apr 4, 2023
@haddadzineddine haddadzineddine changed the title Add feedback for empty attributes in concepts Feature | Add feedback for empty attributes in concepts Apr 24, 2023
Copy link
Collaborator

@syphax-bouazzouni syphax-bouazzouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in our last meeting:

  • Show the warning only if the preferred name is empty
  • Do a better style and reuse the alert component

@syphax-bouazzouni
Copy link
Collaborator

We will need a screenshot when done

@haddadzineddine
Copy link
Author

image

@haddadzineddine
Copy link
Author

haddadzineddine commented May 24, 2023

In this scenario, I display the alert message regardless of the existence of the preferred name, simply to demonstrate that it functions properly.

@syphax-bouazzouni

Screenshot 2023-05-24 203356

@syphax-bouazzouni
Copy link
Collaborator

syphax-bouazzouni commented May 25, 2023

Added:

  • Add padding the concept details no prefLabel warning (d9d463b)
  • Make the concept details no prefLabel alert closable (236d86f)
  • In the concepts treeview the ones with no prefLabel show only their id last part (ae916ac)
image

@syphax-bouazzouni syphax-bouazzouni changed the title Feature | Add feedback for empty attributes in concepts Feature: Add feedback for empty attributes in concepts May 25, 2023
@syphax-bouazzouni syphax-bouazzouni merged commit bf0074a into development May 25, 2023
syphax-bouazzouni added a commit that referenced this pull request Sep 5, 2023
…le-value-text-concept

Feature: Add feedback for empty attributes in concepts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants