Merge to master: Release 2.5.0 - New home, browse, and summary pages UI, in addition to integrating multi-provider authentication #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-design Feature: Update home page design
…vder-authentifcation Feature: Add multi provider Authentication
…vder-authentifcation Fix: Github provider authentification code issue
…issues Bug: Fix responsiveness issues
…issues Fix: Ontology viewer responsiveness issues
…-details-header-design Feature: Update ontology details header design
* re-style persons and organizations section * add safety parameter to metrics variables * re-style identifiers bloc * relocate the projects sections with visits * modify the table of verisons' name to submissions * add the condition to the fair score bloc for logged in and non logged in users * remove contact title * remove creation text from the general information bloc * remove unecessary containers * remove the title " versions" * remove the unecessary code * remove the links bloc to replace it with the identifiers * relocate the methodology bloc * remove projects bloc and relocate it * remove duplicated code * remove static code from the competency question variable * add the date array * add the date array to show the dates section * update Gemfile.lock file * add keywords and keyclasses containers * remove unecessary margins * add the style to modal component * add the function " show dates " to ontologies controllers * remove the duplicated fair score title * remove released column from the submissions table * add prettier file * fix components index style typo issue * add pull url section in summary if user is an the ontology admin * implement projects section in the summary page * fix an issue in the alert message component not showing the content * add circle progress bar component * override bootstrap text-primary color * add submission metadata component * update summary additional metadata content to show all the attributes * add stimulus read more to package.json * show corresponding lang in the tree view * remove audience from aditionnal metadata * add download links array to the download_link function * update the summary page css * re-style the submissions table in the summary page * update the contact and release date information * chnage categories and domains to categories and subjects * remove the old contact information * change the identifier bloc to an open one * add dates bloc to summary page * add the json entry to the links bloc * add projects variables * add methodology bloc * remove visits bloc to relocate it * relocate the visits bloc * add views bloc to the summary page * Show data in platform language when lang is equal to 'all' * fix sort_by in collections and schemes * make the summary two columns bigger * hide the fair score section if not enabled or ontology is AGROVOC * make sub.publication iterable * use tooltip to show language in concept tree links * re-style the fair-score bloc with the new design * re-style fair-score bloc * Auto stash before merge of "feature/update-summary-page-design" and "origin/feature/update-summary-page-design" * re-locate the logo in the summary page * chnage additionnal metadata modal title to all metadata * align the general information and the logo * add function show-category-name to domains section * add summary page dropdown component * add summary section component * extract summary page section to partials * use display_in_multiple_languges methode to show properties in multiple langs * add tooltips to show language in tree view * change 'process_concept' method name to 'language_hash' * define 'display_in_multiple_languages' method * use 'langauge_hash' methode in collection instead of 'process_concept' * cls_id to string * use 'langauge_hash' methode in schemes instead of 'process_concept' * update tooltip controller to support position * use 'langauge_hash' methode in _list_view instead of 'process_concept' * use 'display_in_multiple_languges' to display properties * fix missing 'end' in application helper * display_in_multiple_languges in schemes * fix language_hash method name typo * check if prefLabel is nil * use tooltip to show preLabel lang in schemes * use tooltip to show preLabel lang in collections * use tooltip in collection * fix a typo display_in_multiple_languages function name * extract link_to_scheme helper for schemes tree view * extract helpers to display the collections list view * refactor language related helpers code in application_helper * add language argument to scheme and collection tree links * refactor scheme and collection helpers to make it work for mutli-langs * move submission_metadata into the application helper * extract summary page section to partials * make the summary page responsive * disable summary ontology relation network mouse zoom in/out * move fairness, submission & metrics sections of summary page to bottom * make the submissions table borderless * move see all metadata button to the summary description section bottom * update the usage of the DropdownContainer Component in summary page * fix summary ontology relation network height * use the correct submission description value instead of a placeholder * make the keyClasses of type link clickable * hide Categories and subjects of the summary page if nil or empty * migrate additional_metadata helper to SubmissionMetadataComponent * update Gemfile.lock * remove container fluid for the appliance layout * fix top_nav responsiveness width * fix design on summary page css * update fair score bloc * remove third row section in summary page * Update Fair Score score section * Add persons and organizations variables * fix summary page inline SVG icons * add natural language to the summary page description * hide ontology hasDomain if empty in the summary page * update summary page to make it work for the new keyclasses attribute * Add link component to identifiers section on the summary page * Add css to the identiders section' attributes * updates vis's * update chips button component to have optional html attributes * fix language field to show the lexvo URL if not matched * make label ajax link component use the ChipsButton component * show the go to API in the top let of the ontology viewer * remove the duplicate get_link_for_cls_ajax helper * update keywords section in the summary to use get_link_for_cls_ajax * add show_licences method * add licenses modal file * add licenses modal * put value as nil by default * add condition to license modal * add show license method to ontoloies controller * add or operation to value and content * make field container use content if given value is nil * fix summary fair score not showing because the controller was removed * fix submission edit page container layout * fix topnav raising an issue when session does not contain ontologies * unify the usage of submission_metadata everywhere * use concept_link helper in the concept show view * use ChipButton component for person & organization in summary page * fix field_container margin if using content not the given value * migrate projects and usage information summary section to use components * Remove maring in the class ontology-details-tabs * fix ontology header responsiveness issues * fix ontology-details-header-layout * fix ontology details tabs layout * fix summary page layout * fix summary page responsiveness issues * add metrics evolution popup in the summary page * fix summary page creators input margin bottom in summary page * fix submissions table dropdown button white space * Revert "Merge branch 'feature/update-browse-page-design' into stage" This reverts commit 5bffb8c. * Revert "Merge remote-tracking branch 'refs/remotes/origin/feature/support-multilingual-part-2'" * Remove line 56/57 from .gitignore file * Delete .prettierrc * Delete depiction.svg * Delete github.svg * Delete test_visits.svg * Delete openUp.svg * add depiction section partial * add depiction section partial * Add identifier partial section * Add visits partial * Add all projects partial * add projects partial * Add views partial * Add height line on the chip button * Add condition to versionIRI prop * update chip button * Add properties tables to the ontology controller * Use partials and properties on the summary page * fix bug on the fair score section * add conditions to identifiers * add metrics evolution popup in the summary page * Merge branch 'development' into feature/update-summary-page-design * fix summary page creators input margin bottom in summary page * fix submissions table dropdown button white space * Revert "Merge branch 'feature/update-browse-page-design' into stage" This reverts commit 5bffb8c. * Revert "Merge remote-tracking branch 'refs/remotes/origin/feature/support-multilingual-part-2'" * remove the summary logo placeholder image * fix the drodown button color * fix summary page css * add the tooltip to the dropwon container * add condition to the tooltip usage * fix the field container component * include ApplicationHelper to the summary section component * add the info_tooltip to the card tiltle * add the info_tooltip function to the application helper * add the tooltip to the submission helper * add the tooltip to components on the summary page * add tooltip info to project section * add condition to the icons on the general information section * add tooltip infot to identifiers section * create props array to the projects section * refactor the project section * fix the visits section download arrow * add tootlip to summary page * add ontology viewer style file , for tabs responsiveness * fix a min width for the concept browser * replace open-popup icon with popup-link icon * remove no more used partials in the summary page * migrate submission table to use Table component * clean summary style file and use new icons for ontology relation graph * remove no more used show_depiction and info_tooltip code * fix concept details raw section title padding * use action link slot for summary fairness and submissions sections * update fair score partial design * use component and helpers in summary page partials * migrate submission metadata component to use table component and display_attributes helper * simplify summary ontology_relations_data code * reverse metrics evolution data to have its chart in the right direction * migrate ontology relation network filter to use select input component * remove no more used icons in summary page * simplify ontologies controller summary action by using submission_metadata helper * put again methods used by the index action * handle ontologies with no submission summary page * put temporary help message in summary page section --------- Co-authored-by: Syphax Bouazzouni <gs_bouazzouni@esi.dz> Co-authored-by: Bilel Kihal <61744974+Bilelkihal@users.noreply.github.com>
* Update browse page design with the new design on figma * Fix the problems in the design of the browse page and make it responsive * Add the light color variable for differnet themes * Extract the ontologies section in the browse page to be the src of the turbo frame * Change the color of the turbo progress bar * Update the design of the switch component * Add the checked property to the chips component * Add the filtering logic of the browse page * Add the checked filters count in the browse page * Remove the angular from the browse page * In browse page, limit the ontology description to 3 lines and add a button show more to see the entire description * remove duplicate action changed->turbo-frame#updateFrame in the browser * add text truncate stimulus controller * replace in the browser descriptions js with a controller to show more * add timeago stimulus controller to show dates in a human readable way * add ontology contacts and format to the ontology card * remove old angular files * yarn update to install the new JS dependencies * add ontology browser page and empty state image * refactor useHistory mixin This reverts commit 719e456. * add count slot to the chips components * add small version of the loader component * add filters count by ontology * add the count slots to the chips in the browse page * use turbo streams to update ontologies result and the filters counts * add ontology browse private icon * add admin-color theme variable * add private only switch to the ontologies browser * implement the private only ontologies filter * add title tooltip for the browser filters chips * update turbo_frame component to use a custom loader * handle the case where submission publication attribute is not an array * update infinite scroll component to add custom loader and be generic * create and use tree infinite scroll component * create ontology browser card component * decrease the debounce time of the browser search input * remove no more used get_metrics_hash function * move submission filters methods to a concern module * add back to top button and counter loader to the browse page * implement and use submissions filter concern * create browser ontologies partial * update chips component to add label attribute * update tooltip controller to not show if title is empty * update browse page filters section titles * use the new chips component 'label' attribute for the browser filters * fix the wrong browser count when show private only * migrate the fair score js code to stimulus to make it work with turbo * put again the accidentally removed ontology_params method * prevent zombie submission with no ontology) bug in the browse page * fix browse page layout issues * fix unable to see full content of the filter collapsible block in the browse page * move deprecated and view cards of ontology down instead next to name * remove default margin left of the pill button component * add tooltip message to the ontology that is the view of another ontology * change the layout of the browse page to have the upload button and search in same level * add admin style classes * add interactive option for use tooltip controller * add disabled state to chips component * show the filter count loader each time changed * add released year card to the ontology cards * add the debug card to the ontologies card if user is admin --------- Co-authored-by: Bilelkihal <61744974+Bilelkihal@users.noreply.github.com>
syphax-bouazzouni
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| - values = values.map{|x| x.split(',')}.flatten | ||
| = horizontal_list_container(values) do |v| | ||
| - if link?(v) | ||
| = raw get_link_for_cls_ajax(v, @ontology.acronym, '_blank') |
Check notice
Code scanning / Brakeman
Unescaped parameter value. Note
| %div{style:'width: 50px; height: 50px'} | ||
| - sub_values = sub_hash.values | ||
| - count = sub_values.count{|x| !(x.nil? || x.to_s.empty?)} | ||
| = render CircleProgressBarComponent.new(count: count , max: sub_values.size ) |
Check notice
Code scanning / Brakeman
Render path contains parameter value. Note
syphax-bouazzouni
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites