Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support multilingual - Add read one language from request parameter tests #71

Conversation

syphax-bouazzouni
Copy link

@syphax-bouazzouni syphax-bouazzouni commented Mar 4, 2023

Context

#63

Changes

  • Add tests for the requested language using INRAETHES as the use case
  • Add request_store gem, used to save the requested language as a global variable for the current request.
  • Some code refactoring in the old tests (e.g exist?)

@syphax-bouazzouni syphax-bouazzouni force-pushed the feature/support-multilingual-read-one-language-from-request-parameter branch 4 times, most recently from fd0cb79 to 7ed730a Compare March 6, 2023 13:17
@syphax-bouazzouni syphax-bouazzouni linked an issue Mar 6, 2023 that may be closed by this pull request
4 tasks
@syphax-bouazzouni
Copy link
Author

@haddadzineddine you can review this PR, to see how I added the tests.

Next time, it's your time.

@syphax-bouazzouni syphax-bouazzouni force-pushed the feature/support-multilingual-read-one-language-from-request-parameter branch from 7ed730a to f8c8f56 Compare March 6, 2023 15:29
@syphax-bouazzouni syphax-bouazzouni merged commit 69756f8 into development Mar 6, 2023
syphax-bouazzouni added a commit that referenced this pull request Sep 5, 2023
…gual-read-one-language-from-request-parameter

Feature: Support multilingual - Add read one language from request parameter tests
syphax-bouazzouni added a commit that referenced this pull request Dec 5, 2023
#96)

* fix  json serializer nil exception (#79)

if hash was missing @context key the json serializer throwed a nil exception

* Merge pull request #87 from ontoportal-lirmm/fix/achived-submission-space-optimization

Fix: Archived submission space optimization

* Merge pull request #71 from ontoportal-lirmm/feature/support-multilingual-read-one-language-from-request-parameter

Feature: Support multilingual - Add read one language from request parameter tests

* Merge pull request #73 from ontoportal-lirmm/feature/add-request-language-to-context

Feature/add request language to context

* fix  json serializer nil exception (#79)

if hash was missing @context key the json serializer throwed a nil exception

* Merge pull request #83 from ontoportal-lirmm/feature/add-request-language-to-context

Feature: add request language to context follow up

* Merge pull request #93 from ontoportal-lirmm/support-multi-lang-part-02

Feature: Add request all languages unit test

* Merge pull request #94 from ontoportal-lirmm/feature/support-multi-langual-search

Feature: Support multilangual search

---------

Co-authored-by: Raimi Solorzano Niederhausen <44089477+RaimiSol@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Multilingual: Read one language from request parameter
1 participant