Make batch tasks receive batches of segments #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
My team is hoping to use onyx-local-rt as opposed to regular Onyx because we're running our workflow in a browser/clojurescript environment. We make several API calls that are much more performant in batch mode, so we'd like to take advantage of
batch-fn?.Now, I'm new to this codebase, and to Onyx as a platform, so it's likely that my change is naive. If this is the case, I'm hoping it will at least spark a bit of conversation about what could be done.
Thanks for making Onyx!