Fix setting manifest configurations #137
Conversation
|
Didn't account for Placement changes in |
Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
Since the manifest configuration wasn't being set when consolidateManifests was true, it wasn't being propagated to things like expanded policies and policy template manifests provided directly. This fixes it to set manifest configurations and then compare manifest and policy configurations to make sure they match when consolidateManifests is true. ref: https://issues.redhat.com/browse/ACM-9131 Signed-off-by: Dale Haiducek <19750917+dhaiducek@users.noreply.github.com>
dhaiducek
force-pushed
the
9132-manifest-config
branch
from
e1f6be8
to
6f98d4f
Compare
|
/cherry-pick v1.12 |
|
@dhaiducek: once the present PR merges, I will cherry-pick it on top of v1.12 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhaiducek, mprahl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 98488b5
into
open-cluster-management-io:main
|
@dhaiducek: new pull request created: #138 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ref: https://issues.redhat.com/browse/ACM-9131