Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

viking: Update crates #23

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Conversation

MonsterDruide1
Copy link
Contributor

@MonsterDruide1 MonsterDruide1 commented Apr 16, 2024

nightly-2023-06-28 introduced a breaking change for proc-macro2, with the removal of one of the existing nightly feature. As this is a breaking change and people with newer nightly compilers will fail to build this program, we should update the version of at least proc-macro2.

rust-lang/rust#113152

While we're at it, I also took the liberty of upgrading all other crates specified in Cargo.toml as well, using the output of cargo upgrade. As upgrading addr2line and json_compilation_db requires more changes within the program itself, I did not upgrade those for the moment.

Also, something in those updates fixed some internal issues we were having with the program before: Some function "links" that were not properly recognized before are now picked up and marked as matching (if applicable). It might be worth running a pass of tools/check to individually mark those as matching on the respective decomp repos.


This change is Reviewable

@leoetlino
Copy link
Contributor

Also, something in those updates fixed some internal issues we were having with the program before: Some function "links" that were not properly recognized before are now picked up and marked as matching (if applicable). It might be worth running a pass of tools/check to individually mark those as matching on the respective decomp repos.

Probably the bad64 (AArch64 disassembler) update

@leoetlino leoetlino merged commit d748ec9 into open-ead:master Apr 21, 2024
@MonsterDruide1 MonsterDruide1 deleted the cargo-upgrades branch April 22, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants