chore: remove test sleeps, fix flaky test #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
requested review from
bacherfl,
askpt,
kinyoklion and
austindrenski
toddbaert
force-pushed
the
chore/remove-sleeps-stabilize-tests
branch
from
7943c35
to
76b01e7
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
=======================================
Coverage 93.86% 93.86%
=======================================
Files 23 23
Lines 946 946
Branches 105 105
=======================================
Hits 888 888
Misses 34 34
Partials 24 24 ☔ View full report in Codecov by Sentry. |
toddbaert
commented
Jan 19, 2024
toddbaert
commented
Jan 19, 2024
austindrenski
requested changes
Jan 19, 2024
toddbaert
force-pushed
the
chore/remove-sleeps-stabilize-tests
branch
from
25bb2e1
to
08ffb84
Compare
beeme1mr
approved these changes
Jan 19, 2024
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Co-authored-by: Austin Drenski <austin@austindrenski.io> Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
force-pushed
the
chore/remove-sleeps-stabilize-tests
branch
from
08ffb84
to
3a3ddee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a flaky events test and removes a bunch of sleeps with a new
AssertUntilAsyncutil.It brings the test suite time down to 5s from 15s on my machine.