fix: change $defs to definitions per draft07 #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
requested review from
beeme1mr,
colebaileygit,
thisthat and
Kavindu-Dodan
toddbaert
commented
May 16, 2024
| booleanFlag: | ||
| $comment: merge the variants with the base flag to build our typed flags |
There was a problem hiding this comment.
This is the only unrelated change... for some reason changing $defs to definitions resulted in saying the location of this comment was previously invalid.
thisthat
approved these changes
May 16, 2024
beeme1mr
approved these changes
May 16, 2024
Kavindu-Dodan
approved these changes
May 16, 2024
Merged
toddbaert
pushed a commit
that referenced
this pull request
May 17, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>json/json-schema: 0.2.4</summary> ## [0.2.4](json/json-schema-v0.2.3...json/json-schema-v0.2.4) (2024-05-17) ### 🐛 Bug Fixes * change $defs to definitions per draft07 ([#140](#140)) ([87ab28a](87ab28a)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$defsworks, but it its not part of draft07 which leads to odd warnings in some implementations.I've switched this to
definitionsas per the spec.see: https://json-schema.org/draft-07/draft-handrews-json-schema-validation-01#rfc.section.9
fixes: open-feature/flagd#1309