docs: Buf schema registry readme #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James-Milligan <james@omnant.co.uk>
Signed-off-by: jamesmilligan <james@omnant.co.uk>
james-milligan
commented
Oct 20, 2022
|
|
||
| The core definitions are in the `schema.v1` package, and contains package name options for the following languages, as a result these can be excluded from build instructions: | ||
|
|
||
| - Go: schema/service/v1 |
There was a problem hiding this comment.
while a table would be more suitable here, its formatting is lost in the schema registry
Signed-off-by: jamesmilligan <james@omnant.co.uk>
toddbaert
reviewed
Oct 20, 2022
toddbaert
reviewed
Oct 20, 2022
|
|
||
| The core definitions are in the `schema.v1` package, and contains package name options for the following languages, as such these options may be excluded from build instructions: | ||
|
|
||
| - Go: schema/service/v1 |
There was a problem hiding this comment.
What do you think about taking this chance to update the go package name?
I think I'd like to see something more like the other examples. This is a nitpick though, it won't block the merge from my end.
cc @skyerus
There was a problem hiding this comment.
We have another issue open for this here. I tihnk we should hold off on making this change until after kubecon, as it will change the import paths for flagd and the go provider.
toddbaert
approved these changes
Oct 20, 2022
Co-authored-by: Todd Baert <toddbaert@gmail.com> Signed-off-by: James Milligan <75740990+james-milligan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
#28