Skip to content

Commit

Permalink
fix: Pin byte-buddy(-agent) version to 1.14.19 to workaround Mockito …
Browse files Browse the repository at this point in the history
…issue (#1060)

* fix: Add the net.bytebuddy.experimental=true system property

Workaround to make Mockito tests to pass under Java 21

Signed-off-by: Ryan Prayogo <57620+ryanprayogo@users.noreply.github.com>

* fix: Pin byte-buddy and byte-buddy-agent to a newer version

Signed-off-by: Ryan Prayogo <57620+ryanprayogo@users.noreply.github.com>

* chore: Fix maven warning about deprecated expression

Signed-off-by: Ryan Prayogo <57620+ryanprayogo@users.noreply.github.com>

* chore: Add comments around the Mockito workaround

Signed-off-by: Ryan Prayogo <57620+ryanprayogo@users.noreply.github.com>

* Update pom.xml

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>

---------

Signed-off-by: Ryan Prayogo <57620+ryanprayogo@users.noreply.github.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
  • Loading branch information
ryanprayogo and toddbaert authored Aug 22, 2024
1 parent b7ed041 commit 32340a3
Showing 1 changed file with 19 additions and 1 deletion.
20 changes: 19 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<junit.jupiter.version>5.11.0</junit.jupiter.version>
<!-- exclusion expression for e2e tests -->
<testExclusions>**/e2e/*.java</testExclusions>
<module-name>${groupId}.${artifactId}</module-name>
<module-name>${project.groupId}.${project.artifactId}</module-name>
</properties>

<name>OpenFeature Java SDK</name>
Expand Down Expand Up @@ -151,6 +151,24 @@
<dependencyManagement>
<dependencies>

<!-- Start mockito workaround -->
<!-- https://github.com/mockito/mockito/issues/3121 -->
<!-- These are transitive dependencies of mockito we are forcing -->
<dependency>
<groupId>net.bytebuddy</groupId>
<artifactId>byte-buddy</artifactId>
<version>1.14.19</version>
<scope>test</scope>
</dependency>

<dependency>
<groupId>net.bytebuddy</groupId>
<artifactId>byte-buddy-agent</artifactId>
<version>1.14.19</version>
<scope>test</scope>
</dependency>
<!-- End mockito workaround-->

<dependency>
<groupId>io.cucumber</groupId>
<artifactId>cucumber-bom</artifactId>
Expand Down

0 comments on commit 32340a3

Please sign in to comment.