chore: expose get value for metadata (#468)

expose get value for metadata Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com> Co-authored-by: Justin Abrahms <jabrahms@ebay.com>
open-feature · Jun 9, 2023 · 93dde1d · 93dde1d
1 parent 3946211
commit 93dde1d
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/src/main/java/dev/openfeature/sdk/FlagMetadata.java b/src/main/java/dev/openfeature/sdk/FlagMetadata.java
@@ -77,7 +77,10 @@ public Boolean getBoolean(final String key) {
         return getValue(key, Boolean.class);
     }
 
-    private <T> T getValue(final String key, final Class<T> type) {
+    /**
+     * Generic value retrieval for the given key.
+     */
+    public <T> T getValue(final String key, final Class<T> type) {
         final Object o = metadata.get(key);
 
         if (o == null) {

diff --git a/src/test/java/dev/openfeature/sdk/FlagMetadataTest.java b/src/test/java/dev/openfeature/sdk/FlagMetadataTest.java
@@ -22,11 +22,22 @@ public void builder_validation() {
 
         // then
         assertThat(flagMetadata.getString("string")).isEqualTo("string");
+        assertThat(flagMetadata.getValue("string", String.class)).isEqualTo("string");
+
         assertThat(flagMetadata.getInteger("integer")).isEqualTo(1);
+        assertThat(flagMetadata.getValue("integer", Integer.class)).isEqualTo(1);
+
         assertThat(flagMetadata.getLong("long")).isEqualTo(1L);
+        assertThat(flagMetadata.getValue("long", Long.class)).isEqualTo(1L);
+
         assertThat(flagMetadata.getFloat("float")).isEqualTo(1.5f);
+        assertThat(flagMetadata.getValue("float", Float.class)).isEqualTo(1.5f);
+
         assertThat(flagMetadata.getDouble("double")).isEqualTo(Double.MAX_VALUE);
+        assertThat(flagMetadata.getValue("double", Double.class)).isEqualTo(Double.MAX_VALUE);
+
         assertThat(flagMetadata.getBoolean("boolean")).isEqualTo(Boolean.FALSE);
+        assertThat(flagMetadata.getValue("boolean", Boolean.class)).isEqualTo(Boolean.FALSE);
     }
 
     @Test
@@ -38,7 +49,7 @@ public void value_type_validation() {
                 .build();
 
         // then
-       assertThat(flagMetadata.getBoolean("string")).isNull();
+        assertThat(flagMetadata.getBoolean("string")).isNull();
     }
 
     @Test