fix: improve error logs for evaluation failure #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddbaert
reviewed
Feb 3, 2023
| @@ -137,7 +137,7 @@ private <T> FlagEvaluationDetails<T> evaluateFlag(FlagValueType type, String key | |||
| details = FlagEvaluationDetails.from(providerEval, key); | |||
| hookSupport.afterHooks(type, hookCtx, details, mergedHooks, hints); | |||
| } catch (Exception e) { | |||
| log.error("Unable to correctly evaluate flag with key {} due to exception {}", key, e.getMessage()); | |||
| log.error("Unable to correctly evaluate flag with key '{}'", key, e); | |||
There was a problem hiding this comment.
This simple change will really help, I agree. The message before sometimes came out very confusing.
toddbaert
changed the title
toddbaert
approved these changes
Feb 3, 2023
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
toddbaert
force-pushed
the
chore/improve-error-log
branch
from
00a5115
to
8688284
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes #275
Consider the following log entry with detailed logs explaining the underlying issue by logging stacktrace,