Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Reverse the logic for supportedTypes #24

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

thomaspoignant
Copy link
Member

This PR

This PR reverse in the configuration endpoint how we specify the supported types.

⚠️ Breaking change: since we are still in WIP mode for OFREP we accept this breaking change.
We change the name of the field from unsupportedTypes to supportedTypes.
If not set the default value is to support all the types.

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
service/openapi.yaml Outdated Show resolved Hide resolved
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for switching to supported types

@thomaspoignant thomaspoignant merged commit 21635df into main Jun 11, 2024
3 checks passed
@thomaspoignant thomaspoignant deleted the inverse-logic-unsupported-types branch June 11, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants