Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make openfeature an implicit namespace package #199

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

federicobond
Copy link
Member

This PR

Converts openfeature into an implicit namespace package according to the rules of PEP 420. This allows the code from python-sdk-contrib to be placed under openfeature.contrib thereby creating a single shared top-level namespace between both packages.

Signed-off-by: Federico Bond <federicobond@gmail.com>
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #199 (57ed739) into main (6e87a36) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #199   +/-   ##
=======================================
  Coverage   92.93%   92.93%           
=======================================
  Files          16       16           
  Lines         439      439           
=======================================
  Hits          408      408           
  Misses         31       31           
Flag Coverage Δ
unittests 92.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@beeme1mr beeme1mr merged commit c544918 into open-feature:main Sep 28, 2023
9 checks passed
@federicobond federicobond deleted the namespace-pkg branch September 28, 2023 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants