Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement initialize/shutdown on provider registration #213

Merged
merged 2 commits into from
Oct 18, 2023

Conversation

federicobond
Copy link
Member

This PR

Implements initialize/shutdown on provider registration. Covers Requirements 1.1.2.2, 1.1.2.3 and 1.6.1 from the OpenFeature specification.

Signed-off-by: Federico Bond <federicobond@gmail.com>
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #213 (862be1d) into main (d41cea2) will increase coverage by 0.40%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
+ Coverage   92.93%   93.34%   +0.40%     
==========================================
  Files          16       16              
  Lines         439      451      +12     
==========================================
+ Hits          408      421      +13     
+ Misses         31       30       -1     
Flag Coverage Δ
unittests 93.34% <100.00%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
openfeature/api.py 100.00% <100.00%> (ø)
openfeature/client.py 95.60% <ø> (ø)
openfeature/flag_evaluation.py 97.82% <100.00%> (+0.09%) ⬆️
openfeature/provider/in_memory_provider.py 100.00% <100.00%> (+1.88%) ⬆️
openfeature/provider/provider.py 78.12% <100.00%> (+3.12%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

openfeature/api.py Show resolved Hide resolved
openfeature/api.py Show resolved Hide resolved
@federicobond federicobond merged commit 84af1ae into open-feature:main Oct 18, 2023
9 checks passed
This was referenced Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants