Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update readme based on latest template #227

Merged
merged 11 commits into from
Nov 1, 2023
Merged

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Oct 26, 2023

This PR:

I've tried to get everything right, but there's 4 code-example TODOs. Maybe @jamescarr or @federicobond wouldn't mind filling in those gaps.

@beeme1mr feel free to make any corrections you see.

I also moved the file, but did that in a separate commit. Please see the first commit to see the diff.

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #227 (562da02) into main (0c314ab) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #227   +/-   ##
=======================================
  Coverage   93.84%   93.84%           
=======================================
  Files          16       16           
  Lines         439      439           
=======================================
  Hits          412      412           
  Misses         27       27           
Flag Coverage Δ
unittests 93.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@toddbaert toddbaert force-pushed the chore/update-readme branch 2 times, most recently from 4b62cec to 87e91b1 Compare October 26, 2023 17:19
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert toddbaert marked this pull request as draft October 26, 2023 17:20
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
toddbaert and others added 4 commits October 26, 2023 14:45
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
toddbaert and others added 2 commits October 26, 2023 15:41
Co-authored-by: Federico Bond <federicobond@gmail.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Co-authored-by: Federico Bond <federicobond@gmail.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
@beeme1mr beeme1mr requested a review from tcarrio November 1, 2023 15:06
@beeme1mr beeme1mr marked this pull request as ready for review November 1, 2023 15:07
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@beeme1mr beeme1mr merged commit 1864a3f into main Nov 1, 2023
11 checks passed
@beeme1mr beeme1mr deleted the chore/update-readme branch November 1, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants