refactor!: move AbstractProvider to openfeature.provider #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federicobond
force-pushed
the
refactor/move-provider
branch
from
9c62d29
to
79670c3
Compare
federicobond
force-pushed
the
refactor/move-provider
branch
from
79670c3
to
b09b930
Compare
gruebel
approved these changes
Apr 12, 2024
Signed-off-by: Federico Bond <federicobond@gmail.com>
federicobond
force-pushed
the
refactor/move-provider
branch
from
b09b930
to
8b1baf1
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
==========================================
- Coverage 97.35% 97.32% -0.03%
==========================================
Files 27 26 -1
Lines 1211 1198 -13
==========================================
- Hits 1179 1166 -13
Misses 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves
AbstractProvidertoopenfeature.providermodule.Had to reverse the dependency direction between ProviderStatus and ProviderEvent to avoid a circular dependency.
This release SHOULD allow providers to seamlessly support previous and current versions as long as they update their code before 0.7.0 comes out.