chore: Update Rubocop and pull in recommended plugins

[maxveldink]

This PR

While working on some specification work, I noticed that the version of Rubocop was far behind. Further, Rubocop recommended two extensions when running locally that we should consider including.

• Updates rubocop and pulls in rubocop-rake and rubocop-rspec. I pessimistically locked to the minor version, as Rubocop is generally safe to have a looser versioning constraint in favor of benefiting from new rules sooner.
• Corrected Rubocop violations, either through configuration or minor code changes

Notes

I'll do my best to annotate this PR with the reason behind configuration or code changes; I'm open to discussing any fix here.

One thought I had while working on this is if the project would entertain moving to Standardrb instead of using stock Rubocop. I can add an issue for more discussion, but I am curious about any initial thoughts. Not maintaining an RSpec configuration is nice.

Follow-up Tasks

• Created Failed to upload due to ECONNRESET codecov/codecov-action#71

How to test

Clean Rubocop CI run

[maxveldink]

I typically don't use the development_dependency style and favor using Gemfile, but I opted to use what the project already uses.

[maxveldink]

Since we're using the OpenFeature specification language, disabling this rule as it will constantly be violated.

[maxveldink]

I always find the single default expecation max as overly punitive; I think 2 is a much more reasonable default.

[maxveldink]

Again, since we're using the specification language and nesting, I think having a maximum here is overly restrictive.

[maxveldink]

Discussion around this started in #71

[maxveldink]

I think the pending output is readable enough without a reason.

[technicalpickles]

Thanks for this ✨ I have seen the suggestions, and keep forgetting to do something about them.

One thought I had while working on this is if the project would entertain moving to Standardrb instead of using stock Rubocop. I can add an issue for more discussion, but I am curious about any initial thoughts. Not maintaining an RSpec configuration is nice.

Totally would entertain it. I generally adopt that on new projects because we don't have to talk about rubocop config, except new additive things 😁

[technicalpickles]

Honestly, I think we can remove the versioning. Since we use a Gemfile.lock in the repo, they won't update until they are explicitly bundle update'd.

That makes it a touch easier to update w/o needing to update the gemspec.

[technicalpickles]

@toddbaert hmm, it is the same error as #64 (comment) when trying to report, even with #67

debug - 2023-09-14 00:53:24,761 -- Starting create commit process --- {"commit_sha": "c24ea2244b3606b23931171c81d93bbe9137744c", "parent_sha": null, "pr": "72", "branch": "mveldink/update-rubocop", "slug": "open-feature/ruby-sdk", "token": null, "service": "github", "enterprise_url": null}
Error: Codecov token not found. Please provide Codecov token with -t flag.
Error: Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/845c445181131d954f0198d3d0f26242acc0376e/dist/codecov' failed with exit code 1

[maxveldink]

@technicalpickles Great, I added codecov/codecov-action#74 and will take a stab at switching over to see how much work/reformatting would be involved.

[toddbaert]

@technicalpickles the codecov thing ended up being a big can of worms: codecov/feedback#112.

I'm reverting to an older version for now: #75

[maxveldink]

Closing this since codecov/codecov-action#76 was accepted