[BUG FIX] Remove unnecessary padding during NMS #2584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RunningLeon
reviewed
Dec 6, 2023
| @@ -349,10 +349,6 @@ def _multiclass_nms_single(boxes: Tensor, | |||
| dets = torch.cat([boxes, scores], dim=2) | |||
| labels = cls_inds.unsqueeze(0) | |||
|
|
|||
| # pad | |||
| dets = torch.cat((dets, dets.new_zeros((1, 1, 5))), 1) | |||
There was a problem hiding this comment.
this padding is useful for case when selected_indices is zero shaped tensor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
During deployment of RtmDet-ins models, the output breaks when there are fewer predictions than the "keep_top X" setting. This is caused by padding done to the bbox but not to the masks, so when the top_k are selected, there are more bboxes than masks. This (and previous PR) is a fix for that.
Related to #2571 and #2574.
Modification
Removing unnecessary padding of bbox which is not done to mask.