Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add VOCMeanAP and OIDMeanAP #8

Merged
merged 3 commits into from
Oct 19, 2022
Merged

[Feature] Add VOCMeanAP and OIDMeanAP #8

merged 3 commits into from
Oct 19, 2022

Conversation

ice-tong
Copy link
Collaborator

@ice-tong ice-tong commented Sep 14, 2022 •
edited
Loading

Motivation

Add VOCMeanAP and OIDMeanAP metric.

mmdet PR: open-mmlab/mmdetection#8897

Modification

  • mmeval/detection/voc_map.py
  • mmeval/detection/oid_map.py
  • mmeval/detection/utils/bbox.py
  • mmeval/detection/utils/average_precision.py
  • mmeval/detection/utils/open_images.py

@ice-tong ice-tong changed the base branch from main to yancong/dev-base_metric September 14, 2022 06:31
BIGWangYuDong
BIGWangYuDong reviewed Sep 15, 2022
View reviewed changes
mmeval/detection/voc_map.py Outdated Show resolved Hide resolved
mmeval/detection/voc_map.py Outdated Show resolved Hide resolved
mmeval/detection/voc_map.py Outdated Show resolved Hide resolved
@ice-tong ice-tong changed the base branch from yancong/dev-base_metric to main September 15, 2022 12:19
@ice-tong ice-tong changed the title [WIP][Feat] Add VOCMeanAP [Feat] Add VOCMeanAP Sep 27, 2022
@ice-tong ice-tong changed the title [Feat] Add VOCMeanAP [Feat] Add VOCMeanAP and OIDMeanAP Sep 27, 2022
RangiLyu
RangiLyu reviewed Sep 28, 2022
View reviewed changes
Copy link
Member

@RangiLyu RangiLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reduce the test data size, no need to use the full 600-class hierarchy file.

BIGWangYuDong
BIGWangYuDong reviewed Sep 28, 2022
View reviewed changes
mmeval/detection/oid_map.py Outdated Show resolved Hide resolved
mmeval/detection/oid_map.py Outdated Show resolved Hide resolved
mmeval/detection/utils/bbox.py Outdated Show resolved Hide resolved
BIGWangYuDong
BIGWangYuDong reviewed Sep 28, 2022
View reviewed changes
mmeval/detection/voc_map.py Outdated Show resolved Hide resolved
mmeval/detection/voc_map.py Outdated Show resolved Hide resolved
@ice-tong
Copy link
Collaborator Author

ice-tong commented Sep 29, 2022 •
edited
Loading

Reduce the test data size, no need to use the full 600-class hierarchy file.

Done with the following changes:

  • Use a mini hierarchy JSON within 300 lines. (For each Subcategory, only take the first 10 elements.)
  • Reduce the sample number to 200 in data/openimages_detection.200.pkl
  • Do not use pickle test data.

@ice-tong ice-tong mentioned this pull request Sep 29, 2022
Closed
BIGWangYuDong
BIGWangYuDong approved these changes Sep 30, 2022
View reviewed changes
Copy link
Collaborator

@BIGWangYuDong BIGWangYuDong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ice-tong ice-tong force-pushed the yancong/dev-meanap branch 2 times, most recently from c81ae82 to 058f974 Compare October 14, 2022 01:54
@ice-tong ice-tong force-pushed the yancong/dev-meanap branch 2 times, most recently from 7141a4f to 754a1f9 Compare October 14, 2022 08:52
@zhouzaida
Copy link
Collaborator

Please add more unit tests to cover the invalid inputs.

@ice-tong
Copy link
Collaborator Author

Please add more unit tests to cover the invalid inputs.

Updated

@zhouzaida zhouzaida changed the title [Feat] Add VOCMeanAP and OIDMeanAP [Feature] Add VOCMeanAP and OIDMeanAP Oct 19, 2022
@zhouzaida zhouzaida merged commit 446d470 into main Oct 19, 2022
@zhouzaida zhouzaida deleted the yancong/dev-meanap branch October 19, 2022 02:35
@ice-tong ice-tong mentioned this pull request Nov 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RangiLyu RangiLyu RangiLyu approved these changes

@zhouzaida zhouzaida zhouzaida approved these changes

@ZwwWayne ZwwWayne Awaiting requested review from ZwwWayne

@BIGWangYuDong BIGWangYuDong Awaiting requested review from BIGWangYuDong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ice-tong @zhouzaida @RangiLyu @BIGWangYuDong