Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add OneMinusNormEditDistance for OCR Task #95

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

[Feature] Add OneMinusNormEditDistance for OCR Task #95

wants to merge 6 commits into from

Conversation

Harold-lkk
Copy link
Contributor

@Harold-lkk Harold-lkk commented Feb 15, 2023 •
edited
Loading

@Harold-lkk Harold-lkk mentioned this pull request Feb 15, 2023
Open
C1rN09
C1rN09 reviewed Feb 16, 2023
View reviewed changes
Copy link
Collaborator

@C1rN09 C1rN09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some comments! Also please add the api docs.

mmeval/metrics/one_minus_norm_edit_distance.py Outdated Show resolved Hide resolved
mmeval/metrics/one_minus_norm_edit_distance.py Show resolved Hide resolved
tests/test_metrics/test_one_minus_norm_edit_distance.py Outdated Show resolved Hide resolved
tests/test_metrics/test_one_minus_norm_edit_distance.py Outdated Show resolved Hide resolved
C1rN09
C1rN09 reviewed Mar 2, 2023
View reviewed changes
mmeval/metrics/one_minus_norm_edit_distance.py Outdated Show resolved Hide resolved
mmeval/metrics/one_minus_norm_edit_distance.py Outdated Show resolved Hide resolved
mmeval/metrics/one_minus_norm_edit_distance.py Outdated Show resolved Hide resolved
mmeval/metrics/one_minus_norm_edit_distance.py Outdated Show resolved Hide resolved
mmeval/metrics/one_minus_norm_edit_distance.py Outdated Show resolved Hide resolved
mmeval/metrics/one_minus_norm_edit_distance.py Outdated Show resolved Hide resolved
@Harold-lkk Harold-lkk force-pushed the lkk/OneMinusNormEditDistance branch 2 times, most recently from 823bf0e to 1439ed3 Compare March 6, 2023 02:25
@Harold-lkk Harold-lkk requested review from C1rN09 and removed request for zhouzaida March 6, 2023 02:29
@Harold-lkk Harold-lkk force-pushed the lkk/OneMinusNormEditDistance branch from 1439ed3 to 8781329 Compare March 7, 2023 02:35
C1rN09
C1rN09 approved these changes Mar 9, 2023
View reviewed changes
Copy link
Collaborator

@C1rN09 C1rN09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should rebase to main to pass CI

zhouzaida
zhouzaida reviewed Mar 14, 2023
View reviewed changes
mmeval/metrics/one_minus_norm_edit_distance.py
invalid_symbol: str = '[^A-Za-z0-9\u4e00-\u9fa5]',
**kwargs):
super().__init__(**kwargs)

Copy link
Collaborator

@zhouzaida zhouzaida Mar 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rapidfuzz is not added in runtime.txt so the metric will throw an error when calling add method. The solution is to check it in __init__. Refer to

mmeval/mmeval/metrics/connectivity_error.py

Line 60 in 976f399

raise ImportError(f'For availability of {self.__class__.__name__},'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhouzaida zhouzaida zhouzaida left review comments

@C1rN09 C1rN09 Awaiting requested review from C1rN09 C1rN09 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Harold-lkk @zhouzaida @C1rN09