Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] chore: adding generate operation #3573

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JaydipGabani
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #3501

Special notes for your reviewer:

Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 22.29299% with 122 lines in your changes missing coverage. Please review.

Project coverage is 48.17%. Comparing base (3350319) to head (c6a489a).
Report is 155 commits behind head on master.

Files with missing lines Patch % Lines
pkg/controller/constraint/constraint_controller.go 0.00% 72 Missing ⚠️
...onstrainttemplate/constrainttemplate_controller.go 41.17% 37 Missing and 13 partials ⚠️

❗ There is a different number of reports uploaded between BASE (3350319) and HEAD (c6a489a). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (3350319) HEAD (c6a489a)
unittests 2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3573      +/-   ##
==========================================
- Coverage   54.49%   48.17%   -6.33%     
==========================================
  Files         134      218      +84     
  Lines       12329    15137    +2808     
==========================================
+ Hits         6719     7292     +573     
- Misses       5116     7030    +1914     
- Partials      494      815     +321     
Flag Coverage Δ
unittests 48.17% <22.29%> (-6.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update default for vap once the feature is GAed in k/k
2 participants