Two fixes for virtio-scsi #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise this code leaves the PCI function in a disabled state. The fact that you can boot from virtio-scsi at all today is due to a separate bug in QEMU.
nikunjad
reviewed
May 9, 2017
There was a problem hiding this comment.
: virtio-scsi-add-disk
" scsi-disk.fs" included
;
scsi-disk.fs does have the open and the close functions
https://github.com/open-power-host-os/slof/blob/hostos-devel/slof/fs/scsi-disk.fs#L311
Use the public domain unscii-16 font, the ASCII subset.
cuinutanix
force-pushed
the
hostos-2.0-nutanix
branch
from
0027db6
to
e1ba266
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First is a minor change to be strictly compliant with virtio spec which says the scsi command request header should be 51 bytes, not 56.
The second fixes open-power-host-os/qemu#2. The code structure is lifted from vio-vscsi with some small modifications for virtio-pci.