Added support to get stealable resources from Not Activated lpars #847
Conversation
CPU:Added support to get the procs assigned to not activated lpars and adding them to the max_procs of the target lpar along with the proc available from the CEC Memory:Added support to get the memory assigned to not activated lpars and adding them to the max_memory of the target lpar along with memory available from the CEC Signed-off-by: Shirisha G <shirisha@linux.ibm.com>
common/OpTestHMC.py
Outdated
| @@ -46,7 +46,7 @@ | |||
| from common.OpTestSSH import OpTestSSH | |||
| from common.OpTestUtil import OpTestUtil | |||
| from common.Exceptions import CommandFailed | |||
| #from common.OpTestSystem import OpSystemState | |||
| # from common.OpTestSystem import OpSystemState | |||
There was a problem hiding this comment.
If module not used, Please remove this
There was a problem hiding this comment.
sure Praveen I will check if not needed will remove this
common/OpTestHMC.py
Outdated
| @@ -58,6 +58,7 @@ | |||
| BOOTTIME = 500 | |||
| STALLTIME = 5 | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
why empty line , i feel not needed
| overcommit_ratio*int(min_proc_units), overcommit_ratio*int(desired_proc_units), | ||
| 3*int(max_proc_units),min_memory, desired_memory, max_memory)) | ||
| (sharing_mode, overcommit_ratio*int(min_proc_units), max_proc_units, overcommit_ratio*int(desired_proc_units), | ||
| int(min_proc_units), 2*int(desired_proc_units), |
There was a problem hiding this comment.
any reason to changing in multiplier , is this hold good in all on majority of system
There was a problem hiding this comment.
yes Praveen it works for all the systems.. Am making sure the ratio will be 1:2 in shared mode for PU:VP for desired and max proc units
common/OpTestHMC.py
Outdated
| "lssyscfg -r lpar -m %s -F name state" % self.mg_system) | ||
| # Split the output into lines | ||
| # lines = output.splitlines() | ||
| # Initialize an empty list to store the first column values |
There was a problem hiding this comment.
Please remove commented line and other places as well
There was a problem hiding this comment.
sure will do that
common/OpTestHMC.py
Outdated
| for proc_value in proc: | ||
| stealable_procs.append(int(float(proc_value))) | ||
| total_stealable_proc = sum(stealable_procs) | ||
| print("total stealable proc:", total_stealable_proc) |
There was a problem hiding this comment.
Please use logger to print info and adopt in other places as well
We have some styling issues.So fixed them as well by running autopep8 Signed-off-by: Shirisha G <shirisha@linux.ibm.com>
|
@PraveenPenguin addressed all the above comments |
|
@shirishaganta1 can you please post one run log and we are good to go |
|
|
@PraveenPenguin Done posted the run log. |
CPU:Added support to get the procs assigned to not activated lpars and adding them to the max_procs of the target lpar along with the proc available from the CEC
Memory:Added support to get the memory assigned to not activated lpars and adding them to the max_memory of the target lpar along with memory available from the CEC