Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more reproducible build for rmf-web #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

koonpeng
Copy link

This PR attempts to make the docker builds for rmf-web slightly more reproducible.

  • Fetching of sources is done outside the build to make docker layer caching work. Also makes it easier to integrate with CI/CD as they usually have their own mechanism to fetch sources.
  • Images are tagged with the commit sha of the sources.
  • Use humble compatible commit, remove hacks to force it to build.
    • TODO: The commit is not merged yet, since we use squash merge, it will be gone when it is merged.
  • Remove "hardcoded" rmf dashboard resources, a script is used to fetch the resources instead.
    • For the template, the script is just a dummy that echo some instructions. Users are expected to write their own script if they need custom dashboard resources.

Note that this does not make the build reproducible because it depends on the rmf build. rmf.repos used in the rmf build points to the main branch so every rmf build is potentially different.

Signed-off-by: Teo Koon Peng <koonpeng@openrobotics.org>
Base automatically changed from build/rmf to main August 2, 2022 02:25
@youliangtan
Copy link
Member

I believe with the recent merge of #7, some features mentioned here is now in main. One thing which is missing in the current main:

Remove "hardcoded" rmf dashboard resources, a script is used to fetch the resources instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants