Update README.md with lifecylce node info and fix minor typos #28
Conversation
maverick-g00se
force-pushed
the
branch-updateReadMeWithLifecycleNode
branch
from
b9efb95
to
93c4450
Compare
…-off-by: maverick-g00se mavg00se@gmail.com Signed-off-by: maverick-g00se <mvg00se@gmail.com>
maverick-g00se
force-pushed
the
branch-updateReadMeWithLifecycleNode
branch
from
93c4450
to
c2cc2c6
Compare
Signed-off-by: maverick-g00se <mvg00se@gmail.com>
|
Thanks for the PR. There seems to be some overlap with #19 and since that PR was opened first, we should build off that to attribute changes to the author. |
|
@maverick-g00se thanks for the ping. I've merged #19. Could your rebase this PR before we merge it in? |
Signed-off-by: maverick-g00se <mvg00se@gmail.com>
|
@Yadunund, I have just resolved the existing conflicts :) |
README.md
Outdated
| @@ -1,16 +1,18 @@ | |||
| # rmf_obstacle_detectors | |||
|
|
|||
There was a problem hiding this comment.
I'd prefer not adding a newline after each heading. Same thing for other changes below where a newline is added before a codeblock.
There was a problem hiding this comment.
oops, the auto formatter from work was on. I have fixed them as required. Thanks!
|
Can you ensure your commits are signed so that DCO check passes? |
Bug fix
Fixed bug
As per the suggestion/request in the comments by @Yadunund from issue: #15
Note: PR #19 does attempt to solve the aforementioned as well. However, that PR has been left idle for over 2 weeks so I thought I might give it a whirl :)
Fix applied
Added extra lifecycle node information to the README.md and fixed some other minor typos accordingly as well.