Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing CI. #250

Merged
merged 8 commits into from
Dec 12, 2022
Merged

Fixing CI. #250

merged 8 commits into from
Dec 12, 2022

Conversation

orensbruli
Copy link
Contributor

@orensbruli orensbruli commented Nov 22, 2022 •
edited
Loading

Multiple minor fixes were applied to CI files.
Signed-off-by: Esteban Martinena orensbruli@gmail.com

ahcorde
ahcorde requested changes Nov 22, 2022
View reviewed changes
Copy link

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is still using focal

@orensbruli
Copy link
Contributor Author

CI is still using focal

Do you mean the asan check?

@orensbruli orensbruli force-pushed the emartinena/fixing_CI branch 4 times, most recently from f4c39e2 to 82d6882 Compare December 8, 2022 17:59
This was referenced Dec 8, 2022
Closed
Closed
@orensbruli orensbruli changed the title Fixing CI. Removing Galactic and Focal build. Fixing CI. Dec 8, 2022
@orensbruli orensbruli mentioned this pull request Dec 8, 2022
Closed
@orensbruli orensbruli force-pushed the emartinena/fixing_CI branch 19 times, most recently from 453bfd9 to d691e4c Compare December 9, 2022 18:47
@orensbruli orensbruli force-pushed the emartinena/fixing_CI branch 15 times, most recently from d67594c to 406f6ab Compare December 10, 2022 11:54
@orensbruli
Copy link
Contributor Author

orensbruli commented Dec 10, 2022 •
edited
Loading

The three workflows build, asan and tsan were practically identical (except for the mixins used in colcon build) and are repeated in most RMF repositories.

I have taken advantage of this PR to unify the three into calls to the same reusable workflow found at https://github.com/open-rmf/rmf_ci_templates/blob/main/.github/workflows/reusable_build.yaml.

This workflow has also implemented fixes for known problems with uncrustify in jammy.

gh_pages is still failing and needs some attention (open-rmf/rmf#285 (comment)) but I think we can go with a different issue and PR for that one. Just created: #254

@orensbruli
[CI] Added trigger on push on main branch
1eccbd1 
Galactic and Focal do not distribute NLohmann's JSON >= 3.8.0 which is needed by nlohmann_json_schema_validator
Signed-off-by: Esteban Martinena <orensbruli@gmail.com>

Removed matrix filter

Signed-off-by: Esteban Martinena <orensbruli@gmail.com>

[CI] bush branches main

Signed-off-by: Esteban Martinena <orensbruli@gmail.com>

build

Signed-off-by: Esteban Martinena <orensbruli@gmail.com>
@orensbruli
[CI] Changed push event trigger for gh-pages
eaf6db3 
Signed-off-by: Esteban Martinena <orensbruli@gmail.com>
@orensbruli
[CI] Fixing CI. Moving asan check to jammy humble.
f525380 
Signed-off-by: Esteban Martinena <orensbruli@gmail.com>

asan

Signed-off-by: Esteban Martinena <orensbruli@gmail.com>

[CI] Reusable asan workflow

Signed-off-by: Esteban Martinena <orensbruli@gmail.com>

[ci] Using new merged build and asan workflow

Signed-off-by: Esteban Martinena <orensbruli@gmail.com>
@orensbruli
[CI] Limited asan execution to humble in jammy
4bd84b7 
Signed-off-by: Esteban Martinena <orensbruli@gmail.com>
@orensbruli
[CI] Minor trigger changes
2fb2532 
Signed-off-by: Esteban Martinena <orensbruli@gmail.com>
@orensbruli
[CI] Updated asan mixin
2c31e0a 
Signed-off-by: Esteban Martinena <orensbruli@gmail.com>
@orensbruli
[CI] New tsan workflow
b017e56 
Signed-off-by: Esteban Martinena <orensbruli@gmail.com>
@orensbruli
[CI] Updated to main branch of reusable workflow
e5aae87 
Signed-off-by: Esteban Martinena <orensbruli@gmail.com>
ahcorde
ahcorde requested changes Dec 12, 2022
View reviewed changes
Copy link

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This job is failing github pages / deploy (pull_request)

@orensbruli
Copy link
Contributor Author

This job is failing github pages / deploy (pull_request)

Yes, I mentioned this in my previous comment. I moved to a different issue and PR

gh_pages is still failing and needs some attention (open-rmf/rmf#285 (comment)) but I think we can go with a different issue and PR for that one. Just created: #254

Also, it looks like it has never been used, so we probably should remove that workflow and not spend time fixing it.

@orensbruli orensbruli merged commit 3c17991 into main Dec 12, 2022
@orensbruli orensbruli deleted the emartinena/fixing_CI branch December 12, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orensbruli @ahcorde