Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add main menu option for creating new site #220

Merged
merged 10 commits into from
Jun 6, 2024
Merged

Conversation

mxgrey
Copy link
Collaborator

@mxgrey mxgrey commented Jun 6, 2024

The main purpose of this PR is to support creating new sites from scratch from the main menu. However I'm sneaking in a bug fix and a quality of life improvement that I came up with while testing the process of building sites from scratch:

  • If a list of groups (e.g. fiducials, textures) is being filtered in the selection drop-down menu, include a more... item in the drop down menu that clears the filter
  • Fix the level spawning UI to add all the components that are needed

Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <grey@openrobotics.org>
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
Copy link
Member

@luca-della-vedova luca-della-vedova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small comments

Cargo.lock Outdated Show resolved Hide resolved
rmf_site_editor/src/workspace.rs Show resolved Hide resolved
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
@mxgrey mxgrey merged commit 576e5b6 into main Jun 6, 2024
5 checks passed
@mxgrey mxgrey deleted the add_clear_fiducial_filter branch June 6, 2024 07:27
reuben-thomas pushed a commit to reuben-thomas/rmf_site that referenced this pull request Jun 17, 2024
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
Signed-off-by: Reuben Thomas <reubenthomas123@gmail.com>
reuben-thomas pushed a commit to reuben-thomas/rmf_site that referenced this pull request Jun 19, 2024
Signed-off-by: Michael X. Grey <mxgrey@intrinsic.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants