Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CONTRIBUTING.md #87

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Update CONTRIBUTING.md #87

merged 1 commit into from
Sep 3, 2021

Conversation

kyllingstad
Copy link
Member

No description provided.

@kyllingstad kyllingstad added the documentation Improvements or additions to documentation label Sep 3, 2021
@kyllingstad kyllingstad self-assigned this Sep 3, 2021
@mrindar
Copy link
Contributor

mrindar commented Sep 3, 2021

Where is the APPROVE button? :P

@kyllingstad
Copy link
Member Author

You have to go to the "Files changed" tab and click the green "Review changes" button. It's so you actually have to look at the changes and not approve blindly. ;)

@kyllingstad kyllingstad merged commit fd9a4ba into master Sep 3, 2021
@kyllingstad kyllingstad deleted the feature/update-contributing branch September 3, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrindar mrindar mrindar approved these changes

@ljamt ljamt Awaiting requested review from ljamt

Assignees

@kyllingstad kyllingstad

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyllingstad @mrindar