Fix/feature dimension #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dae
approved these changes
Aug 24, 2023
|
Sorry, I didn't notice you'd requested a review from @asukaminato0721 as well, or I would have waited to merge. |
L-M-Sherlock
added a commit
that referenced
this pull request
Sep 21, 2023
revert modification in Fix/feature dimension (#26)
Merged
dae
pushed a commit
that referenced
this pull request
Sep 22, 2023
* small change * .map(|x| [x]) * reduce noise * remove feature dimension revert modification in Fix/feature dimension (#26) * remove unnecessary unsqueeze() * remove slice * miss some convert * slice to get * remove redundant clone * remove w() to w.val() --------- Co-authored-by: Jarrett Ye <jarrett.ye@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24. It's pretty fast. And I added more tests for the model. Thanks to the support from @nathanielsimard.